This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Make the ODR detector emit errors instead of warnings
- From: Ian Lance Taylor <iant at google dot com>
- To: Jeffrey Yasskin <jyasskin at google dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 27 Jul 2010 01:26:54 -0700
- Subject: Re: [PATCH] Make the ODR detector emit errors instead of warnings
- References: <AANLkTin0OWswSLL0COgMNKK+k=yKFRTbPvC-xHbkYOoQ@mail.gmail.com>
Jeffrey Yasskin <jyasskin@google.com> writes:
> In a large build, it can be very easy to miss a link that emitted
> warnings. Errors are much harder to miss, and seem appropriate for
> problems that cause undefined behavior. If there are false positives,
> users can avoid passing --detect-odr-violations on that link line.
>
> 2010-07-22 Jeffrey Yasskin <jyasskin@google.com>
>
> * symtab.cc (Symbol_table::detect_odr_violations): Change warning to error.
I think --detect-odr-violations can be useful even if there are false
positives; e.g., one could filter the result for known false positives.
You can can use --fatal-warnings if you're sure that you want an error
here.
Ian