This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/4] MIPS/GAS: Reformat the SVR4 PIC JAL test
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: binutils at sourceware dot org, Catherine Moore <clm at codesourcery dot com>, gnu-mips-sgxx at codesourcery dot com
- Date: Wed, 21 Jul 2010 20:05:20 +0100
- Subject: Re: [PATCH 2/4] MIPS/GAS: Reformat the SVR4 PIC JAL test
- References: <alpine.DEB.1.10.1007200153500.29495@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> Given the function is fully annotated with .ent, .end, etc. I
> couldn't resist the temptation to complete symbol attributes by adding a
> .size directive.
Have you noticed any practical difference after adding .size? .ent and
.end should set the size for you, so I'd prefer to keep .size out.
OK otherwise, thanks.
In general, I think it's a bad idea to make cosmetic changes like adding
a space after commas. That's very much down to personal preference;
some asm coders prefer the space whereas others don't. I don't think
adding a space after each comma really qualifies as a "correction".
But go with what you've got as far as that's concerned.
Richard