This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold][patch] Reduce heap usage for string merge sections


Cary Coutant <ccoutant@google.com> writes:

>>> This time with the patch attached.
>>
>> OK, this time with the *right* patch attached. Sorry!
>
> Here's a slight tweak to that patch -- I should have deleted each
> Merged_strings struct after processing it in finalize_merged_data()
> rather than just clearing the list inside it.
>
> The Changelog entry is the same as before.
>
> -cary
>
> diff --git a/gold/merge.cc b/gold/merge.cc
> index e5aa6db..6c512a8 100644
> --- a/gold/merge.cc
> +++ b/gold/merge.cc
> @@ -624,7 +624,7 @@ Output_merge_string<Char_type>::finalize_merged_data()
>             last_output_offset =
>                 this->stringpool_.get_offset_from_key(p->stringpool_key);
>         }
> -      (*l)->merged_strings.clear();
> +      delete *l;

This is OK.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]