This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Don't use i386_is_register in tc_x86_parse_to_dw2regnum
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Wed, 21 Apr 2010 18:00:50 -0700
- Subject: PATCH: Don't use i386_is_register in tc_x86_parse_to_dw2regnum
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi,
tc_x86_parse_to_dw2regnum never calls i386_intel_simplify which
changes O_register to O_constant. There is no need to use
i386_is_register. I am checking in this patch to remove
i386_is_register from tc_x86_parse_to_dw2regnum.
H.J.
---
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/ChangeLog,v
retrieving revision 1.4138
diff -u -p -r1.4138 ChangeLog
--- ChangeLog 22 Apr 2010 00:43:37 -0000 1.4138
+++ ChangeLog 22 Apr 2010 00:57:43 -0000
@@ -1,5 +1,10 @@
2010-04-21 H.J. Lu <hongjiu.lu@intel.com>
+ * config/tc-i386.c (tc_x86_parse_to_dw2regnum): Don't use
+ i386_is_register.
+
+2010-04-21 H.J. Lu <hongjiu.lu@intel.com>
+
* config/tc-i386.c (i386_is_register): Remove is_intel_syntax.
(x86_cons): Updated.
(parse_register): Likewise.
Index: config/tc-i386.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.c,v
retrieving revision 1.433
diff -u -p -r1.433 tc-i386.c
--- config/tc-i386.c 22 Apr 2010 00:43:38 -0000 1.433
+++ config/tc-i386.c 22 Apr 2010 00:57:44 -0000
@@ -8872,7 +8872,7 @@ tc_x86_parse_to_dw2regnum (expressionS *
register_chars['.'] = saved_register_dot;
allow_naked_reg = saved_naked_reg;
- if (i386_is_register (exp) && exp->X_add_number >= 0)
+ if (exp->X_op == O_register && exp->X_add_number >= 0)
{
if ((addressT) exp->X_add_number < i386_regtab_size)
{