Re: PATCH: PR gas/11356: "as -alm" returns very long lines

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Mar 8, 2010 at 4:39 PM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Mar 08, 2010 at 02:51:39PM -0800, H.J. Lu wrote:
>> My fix for PR 9966 didn't check EOL for `\`. ?This patc fixes it. ?OK
>> to install?
>
> No, your logic is still incorrect. ?A backslash quote always lasts for
> exactly one char so the bug was that seen_slash stayed set. ?I think
> the following is right.
>
> ? ? ? ?PR gas/11356
> ? ? ? ?* listing.c (listing_newline): Correct backslash quote logic.
>

How about this patch?

Thanks.

H.J.
---
gas/

2010-03-08  Alan Modra  <amodra@gmail.com>

	PR gas/11356
	* listing.c (listing_newline): Correct backslash quote logic.

gas/testsuite/

2010-03-08  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/9966
	PR gas/11356
	* gas/i386/list-1.l: New.
	* gas/i386/list-1.s: Likewise.
	* gas/i386/list-2.l: Likewise.
	* gas/i386/list-2.s: Likewise.
	* gas/i386/list-3.l: Likewise.
	* gas/i386/list-3.s: Likewise.

	* gas/i386/i386.exp: Run list-1, list-2 and list-3.

	* lib/gas-defs.exp (gas_run_stdin): New.
	(run_list_test_stdin): Likewise.

Attachment: gas-pr11356-2.patch
Description: Text document