This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch][sh] Avoid reading uninitialized data in tc-sh.c
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: ams at codesourcery dot com
- Cc: binutils at sourceware dot org
- Date: Sat, 20 Feb 2010 08:07:02 +0900 (JST)
- Subject: Re: [patch][sh] Avoid reading uninitialized data in tc-sh.c
- References: <4B7E9A8D.4070208@codesourcery.com>
Andrew Stubbs <ams@codesourcery.com> wrote:
> The attached patch corrects a defect in the the SH assembler, found
> using valgrind.
>
> I believe the problem was benign - it was simply checking displacements
> for instructions that needed them, but before it had identified whether
> that instruction was relevant or not. If the random data was out of
> range for the displacement then the instruction was rejected, just as it
> would have been when it was found to be the wrong sort. Real problem or
> not, it's better to silence the warning so as not to hide other real
> problems.
>
> The patch merely moves the displacement checking code until after the
> opcode matching code.
>
> OK?
Could you add the updated copyright year? OK with that
change. Thanks!
Regards,
kaz