This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] Re: Unexpected passes!
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: NightStrike <nightstrike at gmail dot com>
- Cc: binutils <binutils at sourceware dot org>, Kai Tietz <ktietz70 at googlemail dot com>
- Date: Sat, 30 Jan 2010 16:30:56 +0000
- Subject: [committed] Re: Unexpected passes!
- References: <b609cb3b1001292253s5880ed42s39c4cd62b282316e@mail.gmail.com>
On 30/01/2010 06:53, NightStrike wrote:
> I ran the binutils testsuite using binutils HEAD on cygwin as a cross
> compiler to x86_64-w64-mingw32, and I received the following XPASS's!
> Who can update them?
>
> Running /tmp/mw64/build/binutils/src/binutils/testsuite/binutils-all/windres/windres.exp
> ...
> XPASS: windres/html (parse)
> XPASS: windres/html (compare)
> XPASS: windres/lang (parse)
> XPASS: windres/lang (compare)
> XPASS: windres/messagetable (parse)
> XPASS: windres/messagetable (compare)
> XPASS: windres/strtab1 (parse)
> XPASS: windres/strtab1 (compare)
> XPASS: windres/strtab2 (parse)
> XPASS: windres/strtab2 (compare)
> XPASS: windres/version (parse)
> XPASS: windres/version (compare)
> XPASS: windres/version_cat (parse)
> XPASS: windres/version_cat (compare)
I saw those too, in my test results when checking the coff section alignment
extension I just added. I've committed the attached to HEAD.
binutils/testsuite/ChangeLog:
* binutils-all/windres/html.rc: Don't xfail x86_64-*-mingw*.
* binutils-all/windres/lang.rc: Likewise.
* binutils-all/windres/messagetable.rc: Likewise.
* binutils-all/windres/strtab1.rc: Likewise.
* binutils-all/windres/strtab2.rc: Likewise.
* binutils-all/windres/version.rc: Likewise.
* binutils-all/windres/version_cat.rc: Likewise.
cheers,
DaveK
Index: binutils/testsuite/binutils-all/windres/html.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/html.rc,v
retrieving revision 1.1
diff -p -u -r1.1 html.rc
--- binutils/testsuite/binutils-all/windres/html.rc 23 May 2007 08:48:29 -0000 1.1
+++ binutils/testsuite/binutils-all/windres/html.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE LANG_GERMAN, SUBLANG_GERMAN
Index: binutils/testsuite/binutils-all/windres/lang.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/lang.rc,v
retrieving revision 1.3
diff -p -u -r1.3 lang.rc
--- binutils/testsuite/binutils-all/windres/lang.rc 8 Jan 2007 17:21:49 -0000 1.3
+++ binutils/testsuite/binutils-all/windres/lang.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE 0, 0
Index: binutils/testsuite/binutils-all/windres/messagetable.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/messagetable.rc,v
retrieving revision 1.1
diff -p -u -r1.1 messagetable.rc
--- binutils/testsuite/binutils-all/windres/messagetable.rc 23 May 2007 08:48:29 -0000 1.1
+++ binutils/testsuite/binutils-all/windres/messagetable.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE LANG_GERMAN, SUBLANG_GERMAN
Index: binutils/testsuite/binutils-all/windres/strtab1.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/strtab1.rc,v
retrieving revision 1.3
diff -p -u -r1.3 strtab1.rc
--- binutils/testsuite/binutils-all/windres/strtab1.rc 8 Jan 2007 17:21:49 -0000 1.3
+++ binutils/testsuite/binutils-all/windres/strtab1.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE 0, 0
Index: binutils/testsuite/binutils-all/windres/strtab2.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/strtab2.rc,v
retrieving revision 1.1
diff -p -u -r1.1 strtab2.rc
--- binutils/testsuite/binutils-all/windres/strtab2.rc 23 May 2007 08:48:29 -0000 1.1
+++ binutils/testsuite/binutils-all/windres/strtab2.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE 0, 0
Index: binutils/testsuite/binutils-all/windres/version.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/version.rc,v
retrieving revision 1.1
diff -p -u -r1.1 version.rc
--- binutils/testsuite/binutils-all/windres/version.rc 23 May 2007 08:48:29 -0000 1.1
+++ binutils/testsuite/binutils-all/windres/version.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE LANG_GERMAN, SUBLANG_GERMAN
Index: binutils/testsuite/binutils-all/windres/version_cat.rc
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/windres/version_cat.rc,v
retrieving revision 1.1
diff -p -u -r1.1 version_cat.rc
--- binutils/testsuite/binutils-all/windres/version_cat.rc 24 May 2007 11:01:07 -0000 1.1
+++ binutils/testsuite/binutils-all/windres/version_cat.rc 30 Jan 2010 16:06:59 -0000
@@ -1,4 +1,3 @@
-//#xfail x86_64-*-mingw*
#include "windows.h"
LANGUAGE LANG_GERMAN, SUBLANG_GERMAN