This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add amdfam15 flag


On Wed, Jan 6, 2010 at 11:49 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Jan 6, 2010 at 9:20 AM, Quentin Neill
> <quentin.neill.gnu@gmail.com> wrote:
>> On Wed, Jan 6, 2010 at 10:56 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Wed, Jan 6, 2010 at 8:49 AM, Quentin Neill
>>> <quentin.neill.gnu@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> Resubmitting this patch which adds support for -mtune=amdfam15, this
>>>> time with test cases.
>>>>
>>>> Tested with "make -k check".
>>>>
>>>> Okay to commit?
>>>>
>>>> gas/
>>>> ? ? ? ?* config/tc-i386.c (cpu_arch): Add amdfam15.
>>>> ? ? ? ? ?(i386_align_code): Add PROCESSOR_AMDFAM15 cases.
>>>> ? ? ? ?* config/tc-i386.h (processor_type): Add PROCESSOR_AMDFAM15.
>>>> ? ? ? ?* doc/c-i386.texi: Add amdfam15.
>>>>
>>>> opcodes/
>>>> ? ? ? ?* i386-gen.c (cpu_flag_init): Add new CPU_AMDFAM15_FLAGS.
>>>> ? ? ? ?* i386-init.h: Regenerated.
>>>>
>>>> testsuite/
>>>> ? ? ? ?* gas/i386/i386.exp: Add new amdfam15 test cases.
>>>> ? ? ? ?* gas/i386/amdfam15.d: New.
>>>> ? ? ? ?* gas/i386/amdfam15.s: New.
>>>> ? ? ? ?* gas/i386/nops-1-amdfam15.d: New.
>>>> ? ? ? ?* gas/i386/x86-64-amdfam15.d: New.
>>>> ? ? ? ?* gas/i386/x86-64-amdfam15.s: New.
>>>> ? ? ? ?* gas/i386/x86-64-nops-1-amdfam15.d: New.
>>>>
>>>> --
>>>> Quentin
>>>>
>>>> On Mon, Nov 30, 2009 at 9:26 PM, Quentin Neill
>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> This patch adds support for -mtune=amdfam15 to gas.
>>>>>
>>>>> Tested with "make -k check".
>>>>>
>>>>> Okay to commit?
>>>>>
>>>>> ??????? * gas/config/tc-i386.c (cpu_arch): Add amdfam15.
>>>>> ????????? (i386_align_code): Add PROCESSOR_AMDFAM15 cases.
>>>>> ??????? * gas/config/tc-i386.h (processor_type): Add PROCESSOR_AMDFAM15.
>>>>> ??????? * gas/doc/c-i386.texi: Add amdfam15.
>>>>> ??????? * opcodes/i386-gen.c (cpu_flag_init): Add new CPU_AMDFAM15_FLAGS.
>>>>> ??????? * opcodes/i386-init.h: Regenerated.
>>>>>
>>>>> --
>>>>> Quentin Neill
>>>
>>> Do
>>> ? ? ? ?* gas/i386/amdfam15.d: New.
>>> ? ? ? ?* gas/i386/amdfam15.s: New.
>>> ? ? ? ?* gas/i386/x86-64-amdfam15.d: New.
>>> ? ? ? ?* gas/i386/x86-64-amdfam15.s: New.
>>>
>>> add anything which aren't tested before?
>>> --
>>> H.J.
>>
>> I did a search on the mnemonics; no they don't add any new
>> instructions that aren't in *xop.s and x86-64-fma4.s;
>>
>> But they do cover every type of operand in each position in both intel
>> and gas syntax, so there is some value in them.
>
> Please remove them from this patch. If you want, you can
> add them to *xop.s and x86-64-fma4.s in a separate patch.
>
> Thanks.
>
> --
> H.J.
>

Reposting this patch with the requested changes.

Tested with "make -k check".

Okay to commit?

gas/
	* config/tc-i386.c (cpu_arch): Add amdfam15.
	  (i386_align_code): Add PROCESSOR_AMDFAM15 cases.
	* config/tc-i386.h (processor_type): Add PROCESSOR_AMDFAM15.
	* doc/c-i386.texi: Add amdfam15.

opcodes/
	* i386-gen.c (cpu_flag_init): Add new CPU_AMDFAM15_FLAGS.
	* i386-init.h: Regenerated.

testsuite/
	* gas/i386/i386.exp: Add new amdfam15 test cases.
	* gas/i386/nops-1-amdfam15.d: New.
	* gas/i386/x86-64-nops-1-amdfam15.d: New.

-- 
Quentin

Attachment: 7005_amdfam15_gas.diff
Description: Binary data

Attachment: 7005_amdfam15_testsuite.diff
Description: Binary data

Attachment: 7005_amdfam15_opcodes.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]