Re: [PATCH] Objcopy: use a hash table for symbol renaming

[Eirik Byrkjeflot Anonsen <eirik at opera dot com>]

Nick Clifton <nickc@redhat.com> writes:

> Hi Eirik,
>
>> The attached patch replaces the linked list with a hash table
>> implementation.
>
> Thanks for submitting this patch.  It is a good idea, but as
> Hans-Peter has pointed out it would be better to make use of the
> hashing functions that are already implemented in the libiberty
> library, rather than creating your own.

Fully agreed.  I just didn't know that libiberty has a hash table
implementation.  I didn't even know that I was allowed to use libiberty
in binutils.  In fact, you could say I know precious little about
libiberty :)

> Also, with a change of this size, you will need to complete an FSF
> copyright assignment, so that we can make use of your code.  I have
> attached an emailable form which you can fill out in order to start
> this process.

Urgh!  I had forgotten about that.  I'll do that.

eirik