This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add bfd_target_info function to bfd and unify windres/windmc target information gathering


Kai Tietz wrote:
> Dave,
> 
> thanks, here is updated version.

  You still missed one superfluous space:

>  const bfd_target *bfd_find_target (const char *target_name, bfd *abfd);
>  
> +const bfd_target * bfd_get_target_info (const char *target_name,
                     ^
  The asterisk always goes hard up against the symbol, because that's how it
binds (the canonical example being "char* x,y;" vs. "char *x,y;").  Everything
else looked good.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]