This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] bfd/dwarf2.c gives wrong line number for inlined code
> That's still a bit messy. ?This tidies the loop up, and I think still
> has the same exit condition. ?(Should be much easier to add a faster
> search too, if so desired.)
> ...
> [ much simpler version ]
Looks good to me.
I didn't really understand how the code matched this comment, anyway:
/* At this point each_line is NULL but next_line is not. If we found
a candidate end-of-sequence point in the loop above, we can return
that (compatibility with a bug in the Intel compiler); otherwise,
assuming that we found the containing function for this address in
this compilation unit, return the first line we have a number for
(compatibility with GCC 2.95). */
if (*filename_ptr == NULL && function != NULL)
{
*filename_ptr = next_line->filename;
*linenumber_ptr = next_line->line;
return TRUE;
}
I don't see where it ever returned a candidate end-of-sequence point
from the loop above!
-cary