This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH/RFC: ld add -p/-P options
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Matt Rice <ratmice at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 14 Sep 2009 10:09:43 +0930
- Subject: Re: PATCH/RFC: ld add -p/-P options
- References: <8ba6bed40908281313s1938e0a6l9c2676bf5df6b31f@mail.gmail.com> <8ba6bed40908290341t46a3af19w38434d3d76722548@mail.gmail.com> <m3d46bsxks.fsf@google.com> <8ba6bed40909120821q57bf8695y60ec29a793323acb@mail.gmail.com>
On Sat, Sep 12, 2009 at 08:21:35AM -0700, Matt Rice wrote:
> (gld${EMULATION_NAME}_add_options): Add -p and -P options.
There's a small problem here. See armelf.em:PARSE_AND_LIST_SHORTOPTS.
You'll need to get approval from one of the ARM maintainers to remove
that from armelf.em.
> @@ -66,6 +66,7 @@ static void gld${EMULATION_NAME}_before_
> static void gld${EMULATION_NAME}_after_allocation (void);
> static lang_output_section_statement_type *gld${EMULATION_NAME}_place_orphan
> (asection *, const char *, int);
> +static void gld${EMULATION_NAME}_append_to_separated_string(char **, char *);
No need for a prototype.
> @@ -2048,6 +2053,45 @@ fragment <<EOF
>
> #define DEFAULT_BUILD_ID_STYLE "sha1"
>
> +static void
> +gld${EMULATION_NAME}_append_to_separated_string(char **to, char *optarg)
Space before (. Other than that the patch looks good.
--
Alan Modra
Australia Development Lab, IBM