This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH/RFC: ld add -p/-P options


On Sat, Sep 12, 2009 at 08:21:35AM -0700, Matt Rice wrote:
> 	(gld${EMULATION_NAME}_add_options): Add -p and -P options.

There's a small problem here.  See armelf.em:PARSE_AND_LIST_SHORTOPTS.
You'll need to get approval from one of the ARM maintainers to remove
that from armelf.em.

> @@ -66,6 +66,7 @@ static void gld${EMULATION_NAME}_before_
>  static void gld${EMULATION_NAME}_after_allocation (void);
>  static lang_output_section_statement_type *gld${EMULATION_NAME}_place_orphan
>    (asection *, const char *, int);
> +static void gld${EMULATION_NAME}_append_to_separated_string(char **, char *);

No need for a prototype.

> @@ -2048,6 +2053,45 @@ fragment <<EOF
>  
>  #define DEFAULT_BUILD_ID_STYLE	"sha1"
>  
> +static void 
> +gld${EMULATION_NAME}_append_to_separated_string(char **to, char *optarg)

Space before (.  Other than that the patch looks good.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]