This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390: Fix objdump output of larl operand - take 2


"Andreas Krebbel" <krebbel@linux.vnet.ibm.com> writes:

> @@ -222,7 +222,8 @@ print_insn_s390 (bfd_vma memaddr, struct
>  	      else if (operand->flags & S390_OPERAND_CR)
>  		(*info->fprintf_func) (info->stream, "%%c%i", value);
>  	      else if (operand->flags & S390_OPERAND_PCREL)
> -		(*info->print_address_func) (memaddr + (int) value, info);
> +		(*info->print_address_func) (memaddr +
> +					     (((long long)(int)value) << 1), info);

How about (memaddr + (int) value + (int) value)?  That avoids the
overflow without the need for long long.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]