This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch 0/3] Fix some FAILS for: unordered .debug_info references to .debug_ranges
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 9 Sep 2009 19:01:39 +0930
- Subject: Re: [patch 0/3] Fix some FAILS for: unordered .debug_info references to .debug_ranges
- References: <20090907033218.GA20107@host0.dyn.jankratochvil.net>
On Mon, Sep 07, 2009 at 05:32:18AM +0200, Jan Kratochvil wrote:
> These targets:
> i686-pc-cygwin mingw32-pe x86_64-mingw32
>
> fail on
> ./configure --target=$TARGET --enable-targets=all; make
>
> with
> config/tc-i386.c: In function 'i386_target_format':
> config/tc-i386.c:8099: error: duplicate case value
> config/tc-i386.c:8088: error: previously used here
>
> This failure was already present before my patch
> [patch 1/4] Fix compilation for i386-unknown-go32 with secondary as elf
> http://sourceware.org/ml/binutils/2009-08/msg00152.html
>
> and I will post a separate patch for it.
I haven't yet seen a patch for this problem, so I'm going ahead and
committing this one.
* config/tc-i386.c (i386_target_format): Avoid duplicate case label.
Index: gas/config/tc-i386.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.c,v
retrieving revision 1.391
diff -u -p -r1.391 tc-i386.c
--- gas/config/tc-i386.c 29 Aug 2009 22:10:59 -0000 1.391
+++ gas/config/tc-i386.c 9 Sep 2009 07:34:06 -0000
@@ -8084,20 +8084,21 @@ i386_target_format (void)
as_fatal (_("Unknown architecture"));
switch (OUTPUT_FLAVOR)
{
-#if defined (TE_PE) || defined (TE_PEP)
- case bfd_target_coff_flavour:
- return flag_code == CODE_64BIT ? "pe-x86-64" : "pe-i386";
-#endif
-#ifdef OBJ_MAYBE_AOUT
+#if defined (OBJ_MAYBE_AOUT) || defined (OBJ_AOUT)
case bfd_target_aout_flavour:
return AOUT_TARGET_FORMAT;
#endif
-#ifdef TE_GO32
+#if defined (OBJ_MAYBE_COFF) || defined (OBJ_COFF)
+# if defined (TE_PE) || defined (TE_PEP)
+ case bfd_target_coff_flavour:
+ return flag_code == CODE_64BIT ? "pe-x86-64" : "pe-i386";
+# elif defined (TE_GO32)
case bfd_target_coff_flavour:
return "coff-go32";
-#elif defined (OBJ_MAYBE_COFF)
+# else
case bfd_target_coff_flavour:
return "coff-i386";
+# endif
#endif
#if defined (OBJ_MAYBE_ELF) || defined (OBJ_ELF)
case bfd_target_elf_flavour:
--
Alan Modra
Australia Development Lab, IBM