This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] opcodes/z8k-opc.h regenerated


On Mon, Sep 07, 2009 at 03:05:58PM +0200, Andreas Schwab wrote:
> Not sure whether you can count on p1 != p2.

Does it matter?  Seems to me if qsort calls the comparison function
with p1 == p2, then it doesn't matter whether qsort "swaps" those
entries or not.  It would be a rather poor qsort implementation that
did this and then didn't terminate..

>  A common idiom is (p1 > p2) - (p1 < p2).

Feel free to fix it if you think this is necessary, or even just
desirable as the Right Thing To Do.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]