This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/10433: Latest ld fails to link ldconfig properly


On Wed, Jul 22, 2009 at 4:34 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> On Wed, Jul 22, 2009 at 02:32:27PM -0700, H.J. Lu wrote:
>> Hi,
>>
>> A STT_GNU_IFUNC symbol goes through PLT only if it is ever referenced.
>> I checked in this patch to fix it.
>
> You don't have global authority to commit patches. ?I'd normally let
> this sort of patch pass, but I quite clearly explained why I removed
> your test of ref_regular before. ?Please revert this patch and instead
> fix it in your target finish_dynamic_symbol.
>

I disagree. If ref_regular isn't set properly, IFUNC may not work
properly at all. I will revert my patch and move it to the Linux
binutils instead.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]