This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, ARM] Don't pass incorrect pointer in arm_build_one_stub
- From: Daniel Jacobowitz <drow at false dot org>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: binutils at sourceware dot org, Doug Kwan <dougkwan at google dot com>
- Date: Fri, 10 Jul 2009 10:06:48 -0400
- Subject: Re: [PATCH, ARM] Don't pass incorrect pointer in arm_build_one_stub
- References: <20090710141535.6be29db4@rex.config>
On Fri, Jul 10, 2009 at 02:15:35PM +0100, Julian Brown wrote:
> Hi,
>
> This patch passes the hash for a symbol from which a stub entry was
> derived, not the hash for the stub entry itself, to
> elf32_arm_final_link_relocate. This fixes a potential incorrect code
> generation issue (not seen on mainline so far, AFAIK). In practice,
> there will be no symbols for the stubs in question, so the value passed
> should always be NULL (though a non-NULL value would be passed prior to
> this patch, which could cause elf32_arm_final_link_relocate to get
> confused).
>
> (Thanks to Doug for noticing this on mainline.)
>
> OK to apply?
OK.
--
Daniel Jacobowitz
CodeSourcery