Re: [patch] Updated plugin support for bfd

[Rafael Espindola <espindola at google dot com>]

> well you've done real testing, so i wont complain there.

Actually, I was asked to do so in a previous code review. I have never
coded on Solaris :-)

> Âif the code is going
> to be copied verbatim to different places, perhaps it makes sense to make a
> simple m4 file for it ? Âmaybe in the config/ subdir ? Âthen we wont have to
> worry about changes in one place bit rotting in others ...

Good point. The attached patch does just the code factoring. Is it OK?

2009-05-26  Rafael Avila de Espindola  <espindola@google.com>

	* aclocal.m4: Include ../config/solaris-lfs.m4
	* configure: Regenerate.
	* configure.in: Use AC_SOLARIS_LFS.

2009-05-26  Rafael Avila de Espindola  <espindola@google.com>

	* aclocal.m4: Include ../config/solaris-lfs.m4
	* configure: Regenerate.
	* configure.in: Use AC_SOLARIS_LFS.

2009-05-26  Rafael Avila de Espindola  <espindola@google.com>

	* solaris-lfs.m4: New.


> -mike
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047

diff --git a/bfd/aclocal.m4 b/bfd/aclocal.m4
index 208fad9..60a84a8 100644
--- a/bfd/aclocal.m4
+++ b/bfd/aclocal.m4
@@ -867,6 +867,7 @@ m4_include([../config/po.m4])
 m4_include([../config/proginstall.m4])
 m4_include([../config/progtest.m4])
 m4_include([../config/stdint.m4])
+m4_include([../config/solaris-lfs.m4])
 m4_include([../libtool.m4])
 m4_include([../ltoptions.m4])
 m4_include([../ltsugar.m4])
diff --git a/bfd/configure.in b/bfd/configure.in
index 81255dd..e7713f4 100644
--- a/bfd/configure.in
+++ b/bfd/configure.in
@@ -23,22 +23,7 @@ AC_PROG_CC
 AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
-case "${target}" in
-changequote(,)dnl
-  sparc-*-solaris*|i[3-7]86-*-solaris*)
-changequote([,])dnl
-    # On native 32bit sparc and ia32 solaris, large-file and procfs support
-    # are mutually exclusive; and without procfs support, the elf module
-    # cannot provide certain routines such as elfcore_write_prpsinfo
-    # or elfcore_write_prstatus.  So unless the user explicitly requested
-    # large-file support through the --enable-largefile switch, disable
-    # large-file support in favor of procfs support.
-    if test "${target}" = "${host}" -a "$enable_largefile" != 'yes'; then
-      enable_largefile="no"
-    fi
-    ;;
-esac
-
+AC_SOLARIS_LFS
 AC_SYS_LARGEFILE
 
 LT_INIT
diff --git a/binutils/aclocal.m4 b/binutils/aclocal.m4
index 39857e5..2b33823 100644
--- a/binutils/aclocal.m4
+++ b/binutils/aclocal.m4
@@ -892,6 +892,7 @@ m4_include([../config/override.m4])
 m4_include([../config/po.m4])
 m4_include([../config/proginstall.m4])
 m4_include([../config/progtest.m4])
+m4_include([../config/solaris-lfs.m4])
 m4_include([../libtool.m4])
 m4_include([../ltoptions.m4])
 m4_include([../ltsugar.m4])
diff --git a/binutils/configure.in b/binutils/configure.in
index e35b169..fe8c008 100644
--- a/binutils/configure.in
+++ b/binutils/configure.in
@@ -16,20 +16,7 @@ AC_PROG_CC
 AC_GNU_SOURCE
 AC_USE_SYSTEM_EXTENSIONS
 
-case "${target}" in
-changequote(,)dnl
-  sparc-*-solaris*|i[3-7]86-*-solaris*)
-changequote([,])dnl
-    # See comment in bfd/configure.in for the reason for this test.
-    # PR 9992/binutils: We have to duplicate the behaviour of bfd's
-    # configure script so that the utilities in this directory agree
-    # on the size of structures used to describe files.
-    if test "${target}" = "${host}" -a "$enable_largefile" != 'yes'; then
-      enable_largefile="no"
-    fi
-    ;;
-esac
-
+AC_SOLARIS_LFS
 AC_SYS_LARGEFILE
 LT_INIT
 
diff --git a/config/solaris-lfs.m4 b/config/solaris-lfs.m4
new file mode 100644
index 0000000..fe0ba04
--- /dev/null
+++ b/config/solaris-lfs.m4
@@ -0,0 +1,18 @@
+AC_DEFUN([AC_SOLARIS_LFS],
+[
+  case "${target}" in
+  changequote(,)dnl
+    sparc-*-solaris*|i[3-7]86-*-solaris*)
+  changequote([,])dnl
+      # On native 32bit sparc and ia32 solaris, large-file and procfs support
+      # are mutually exclusive; and without procfs support, the elf module
+      # cannot provide certain routines such as elfcore_write_prpsinfo
+      # or elfcore_write_prstatus.  So unless the user explicitly requested
+      # large-file support through the --enable-largefile switch, disable
+      # large-file support in favor of procfs support.
+      if test "${target}" = "${host}" -a "$enable_largefile" != 'yes'; then
+        enable_largefile="no"
+      fi
+      ;;
+  esac
+])