This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch i386 pe]: Allow multilib version gas for i386 pe-coff
On Tue, May 19, 2009 at 4:03 PM, Dave Korn
<dave.korn.cygwin@googlemail.com> wrote:
> H.J. Lu wrote:
>
>> --- gas/config/obj-coff.h.foo 2007-10-30 11:48:38.000000000 -0700
>> +++ gas/config/obj-coff.h ? ? 2009-05-19 15:03:51.000000000 -0700
>> @@ -61,16 +61,6 @@
>> ?#include "coff/i386.h"
>> ?#endif
>>
>> -#ifdef TE_PE
>> -#ifdef TE_PEP
>> -extern const char *i386_target_format (void);
>> -#define TARGET_FORMAT i386_target_format ()
>> -#define COFF_TARGET_FORMAT "pe-x86-64"
>> -#else
>> -#define TARGET_FORMAT "pe-i386"
>> -#endif
>> -#endif
>> -
>> ?#ifndef TARGET_FORMAT
>> ?#ifdef TE_PEP
>> ?#define TARGET_FORMAT "coff-x86-64"
>
> ?Since this breaks a pattern (of having cpu-dependent TARGET_FORMAT
> definition in obj-coff.h), perhaps we should leave a comment behind in place
> of this deletion, explaining where it went and why.
I don't think there is such a patten:
tc-alpha.h:#define TARGET_FORMAT (OUTPUT_FLAVOR == bfd_target_ecoff_flavour \
tc-arm.h:# define TARGET_FORMAT (target_big_endian ? "coff-arm-big" :
"coff-arm-little")
tc-m68k.h:#define TARGET_FORMAT "coff-m68k-aux"
tc-m68k.h:#define TARGET_FORMAT "coff-m68k-sysv"
tc-or32.h:#define TARGET_FORMAT "coff-or32-big"
tc-z8k.h:#define TARGET_FORMAT "coff-z8k"
--
H.J.