This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch i386 pe]: Allow multilib version gas for i386 pe-coff
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 19 May 2009 06:58:46 -0700
- Subject: Re: [patch i386 pe]: Allow multilib version gas for i386 pe-coff
- References: <90baa01f0905190442y529073f3ue12260c9e0a8852a@mail.gmail.com>
On Tue, May 19, 2009 at 4:42 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> Hello,
>
> this patch enables the build of gas for 32-bit defaulted multilib
> version of gas.
>
> ChangeLog
> 2009-05-19 ?Kai Tietz ?<kai.tietz@onevision.com>
>
> ? ? ? ?* config/tc-i386.c (md_longopts): Allow --64 for x86 pe-coff.
> ? ? ? ?(OPTION_64): Likewise.
> ? ? ? ?(md_show_usage): Show option --32/--64.
> ? ? ? ?(i386_target_format): Use also for x86 pe-coff.
> ? ? ? ?* config/obj-coff.h (COFF_TARGET_FORMAT): Define as
> ? ? ? ?pe-i386.
> ? ? ? ?(TARGET_FORMAT): Define as i386_target_format ().
>
> Tested for i686-pc-cygwin, i686-pc-mingw32, x86_64-pc-mingw32, and as
> multilib version of i686-w64-mingw32.
>
> Is this patch ok for apply?
Can you move the whole
---
#ifdef TE_PE
#ifdef TE_PEP
extern const char *i386_target_format (void);
#define TARGET_FORMAT i386_target_format ()
#define COFF_TARGET_FORMAT "pe-x86-64"
#else
#define TARGET_FORMAT "pe-i386"
#endif
#endif
#ifndef TARGET_FORMAT
#ifdef TE_PEP
#define TARGET_FORMAT "coff-x86-64"
#else
#define TARGET_FORMAT "coff-i386"
#endif
#endif
#endif
---
from obj-coff.h to tc-i386.h?
--
H.J.