This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: broken strip/objcopy


Kai Tietz wrote:

> Ah, I found the major issue here

  That was quick!  I was going to suggest that we surely /ought/ to be able to
determine and use the right format.

>         PR binutils/10074
> 
> This patch made objcopy and strip for PE-Coff target 32-bit PE only.
> This patch should fix it.
> 
> ChangeLog
> 
> 2009-04-24  Kai Tietz  <kai.tietz@onevision.com>
> 
> 	* objcopy.c (pep_objcopy.h): Add include.
> 	(copy_object): Add check for PE+ x86_64
> 	and call for it pep_copy_object.
> 	* pep_objcopy.c: New file.
> 	(pep_copy_object): New implementation.
> 	* pep_objcopy.h: New include.
> 	(pep_copy_object): New declaration.
> 	* Makefile.am: Add pep_objcopy.c to make.
> 	* Makefile.in: Regenerated.
> 
> Tested for x86_64-pc-mingw32. Ok for apply?

  Are you sure we can't do this without a whole new file?  What actually works
out different - struct offsets?

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]