This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [3/21] Keep .text, .data and .bss on AIX


Nick Clifton <nickc@redhat.com> writes:
> Hi Richard,
>
>> ld/
>> 	* emultempl/aix.em (gld${EMULATION_NAME}_before_allocation): Mark
>> 	.text, .data and .bss output sections as SEC_KEEP.
>> 
>> ld/testsuite/
>> 	* ld-powerpc/aix-core-sec-1.s, ld-powerpc/aix-core-sec-1.ex,
>> 	ld-powerpc/aix-core-sec-1.hd, ld-powerpc/aix-core-sec-2.s,
>> 	ld-powerpc/aix-core-sec-2.ex, ld-powerpc/aix-core-sec-2.hd,
>> 	ld-powerpc/aix-core-sec-3.s, ld-powerpc/aix-core-sec-3.ex,
>> 	ld-powerpc/aix-core-sec-3.hd: New tests.
>> 	* ld-powerpc/aix52.exp: New harness.
>
> Approved - please apply - although ... :-)
>
>> +	  einfo ("%P: can't find output section %s\n", must_keep_sections[i]);
>
> I would suggest changing the wording to "can't find required output 
> section" as otherwise the user might think: "well so what if I don't 
> have a .bss section, who cares ?".

Yeah, I agree that's better.  Applied with that change, thanks.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]