This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: ARM long branch stubs: cleanup
- From: Daniel Jacobowitz <drow at false dot org>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org, Christophe LYON <christophe dot lyon at st dot com>
- Date: Mon, 9 Mar 2009 09:20:47 -0400
- Subject: Re: ARM long branch stubs: cleanup
- References: <49B157BD.4090609@st.com> <200903091303.57928.paul@codesourcery.com>
On Mon, Mar 09, 2009 at 01:03:57PM +0000, Paul Brook wrote:
> On Friday 06 March 2009, Christophe LYON wrote:
> > Hi all,
> >
> > With the attached small patch, I propose to remove an error-prone switch
> > statement to get the correct stub template and size in arm_size_one_stub().
> > It is replaced by an (error-prone :-) array defined next to the stub
> > themselves.
> >
> > Maybe it would save some maintenance issues.
>
> If you rework the preprocessor macros a bit you can generate both the enum and
> the array from the same list.
But then you get backslashes all over the place - is it an
improvement?
--
Daniel Jacobowitz
CodeSourcery