This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Silence ld auto-import warnings for pe-i386.


Dave Korn wrote:
> Dave Korn wrote:
> 
>>   Tested natively on i686-pc-cygwin with no regressions 
> 
>   Argh, how did I miss that?  There is one new FAIL, ld-pe/.secrel32, which
> has a mismatch in the objdump output owing to the fact that .rdata is now
> being placed in .data.  I'll have a follow-on patch to adjust the .d file so
> that the regexps match the new output shortly.

  Attached.  Rather than try and match two different patterns of section
assignment on different targets according to default auto-import behaviour, I
just disable it for the test.  OK if other patch is OK?

ld/testsuite/ChangeLog

	* ld-pe/pe.exp:  Disable auto-import when linking on Cygwin.

    cheers,
      DaveK
Index: ld/testsuite/ld-pe/pe.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/pe.exp,v
retrieving revision 1.8
diff -p -u -r1.8 pe.exp
--- ld/testsuite/ld-pe/pe.exp	6 Aug 2007 14:41:51 -0000	1.8
+++ ld/testsuite/ld-pe/pe.exp	26 Feb 2009 14:58:39 -0000
@@ -34,6 +34,11 @@ if {[istarget x86_64-*-mingw*] } {
     {".secrel32" "" "" {secrel1.s secrel2.s}
     {{objdump -s secrel_64.d}} "secrel.x"}
   }
+} elseif {[istarget i*86-*-cygwin*] } {
+  set pe_tests {
+    {".secrel32" "--disable-auto-import" "" {secrel1.s secrel2.s}
+     {{objdump -s secrel.d}} "secrel.x"}
+  }
 } else {
   set pe_tests {
     {".secrel32" "" "" {secrel1.s secrel2.s}

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]