Re: GDB multi-build failure in lm32-opc.c file

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Pierre Muller wrote:
> Dave Korn a écrit :

>>   Does that still work at -O0?
> 
>   You are right, this is not sure at all...
> But I tried it out, and got no error recompiling
> opcodes directory with
> make clean all CFLAGS="-g -O0"

  Ah, the warning must depend on optimisation then.  Guess the fix is fine as
it is.

>   I was wondering if we should add some
> comment inside the source files themselves to explain
> why this condition was added...

  That would be a good idea come to think of it, or someone might optimise it
away somewhere down the line.

>   Would my GDB assignment be OK for a commit to opcodes?
> This is really part of the code I need to compile GDB,
> so it should be OK, no?

  I'm sure it is, and in any case, all this stuff is small enough not to worry
about an assign anyway.  Add the comment to your patch and resubmit it with a
ChangeLog entry and we'll get it accepted.

    cheers,
      DaveK