This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Correct interpretation of IMAGE_SCN_MEM_DISCARDABLE in coffcode.h


Nick Clifton <nickc@redhat.com> wrote on 16.01.2009 11:22:12:

> Hi Kai,
> 
> > Thank you for giving me a hint. I altered the patch, so that it sets 
> > DEBUGGING for .debug*, .stab*, .comment, and .gnu.linkonce.wi.* 
sections.
> > 
> > Ok, for apply?
> 
> Approved - please apply; except - please could you adjust the wording of 

> the comment slightly.  Instead of:
> 
>    /* The MS PE spec says, that debug sections are DISCARDABLE,
>       but the DISCARDABLE flag has not the meaning of being debug.
>       So just set SEC_DEBUGGING for them.  */
> 
> please could we have:
> 
>    /* The MS PE spec says that debug sections are DISCARDABLE,
>       but the presence of a DISCARDABLE flag does not necessarily
>       mean that a given section contains debug information.  Thus
>       we only set the SEC_DEBUGGING flag on sections that we
>       recognise as containing debug information.  */
> 
> Cheers
>    Nick
> 

Hi Nick,

I adjusted the comment as you suggested and applied patch.

Cheers,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]