This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/9679: Linker doesn't merge visibility of weak symbol


On Fri, Jan 2, 2009 at 8:21 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
>> bfd/
>> 2008-12-22  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>        PR ld/9676
>>        * elflink.c (elf_link_add_object_symbols): Update def_dynamic,
>>        ref_dynamic and dynamic_def fields when setting def_regular
>>        to 1.
>>
>> ld/testsuite/
>> 2008-12-22  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>        PR ld/9676
>>        * ld-elf/pr9676-1.c: New.
>>        * ld-elf/pr9676-2.c: Likewiswe.
>>        * ld-elf/pr9676-3.c: Likewiswe.
>>        * ld-elf/pr9676-4.c: Likewiswe.
>>
>>        * ld-elf/shared.exp (build_tests): Add tests for libpr9676-1.a,
>>        libpr9676-2.a, libpr9676-3.so, libpr9676-4.so and
>>        libpr9676-4a.so.
>>
>>        * lib/ld-lib.exp (ar_simple_create): New.
>>        (run_ld_link_tests): Support archive.
>>        (run_cc_link_tests): Likewiswe.
>
> Approved - please apply.
>

I checked in a slightly different testcase to check symbol in the output.

Nick, your reply is odd. My message you quoted is from

http://sourceware.org/ml/binutils/2008-12/msg00247.html

But it has a different subject:

Re: PATCH: PR ld/9676: link-failure: could not read symbols: Bad value

The subject of your reply matches:

http://sourceware.org/ml/binutils/2008-12/msg00241.html

which is for PR 9679:

http://www.sourceware.org/bugzilla/show_bug.cgi?id=9679

I am enclosing an updated patch with a testcase.  OK to install?

Thanks.

-- 
H.J.

Attachment: binutils-weak-1.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]