This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: Patch for wince
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: Kai Tietz <ktietz70 at googlemail dot com>, binutils <binutils at sourceware dot org>
- Date: Thu, 1 Jan 2009 12:22:42 -0500
- Subject: Re: [patch]: Patch for wince
- References: <90baa01f0901010758x16e9c205tf88da08562b84a97@mail.gmail.com>
On Thu, Jan 01, 2009 at 04:58:26PM +0100, Kai Tietz wrote:
>this patch fixes a problem about wince and the windres tool.
>
>ChangeLog
>
>2009-01-01 Kai Tietz <kai.tietz@onevision.com>
>
> * windres.c (set_endianess): Cut name between '-' for search.
>
>I tested this patch on mingwce and on x86_64-pc-mingw32.
>
>Is it ok for apply?
I don't think so. You need to provide more details about what you're fixing.
You shouldn't use "l" (ell) as a variable name because, IMO, it looks
too much like a 1 (one).
And you really, really shouldn't introduce a ^M into source files.
Couldn't you use alloca here to allocate new_tname and avoid a xmalloc?
cgf