This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 2.19 -enable-targets=all one error in m68k-dis.c due to longjmp, easily fixed with volatile


Hi Andreas,

+ static fprintf_ftype save_printer;
+ static void (* save_print_address) (bfd_vma, struct disassemble_info *);

This is wrong, these variables are never set. The save/restore part should be completely local to match_insn_m68k, no other function should need to touch them.

Good point - that was a hold over from a previous version of the patch. Sorry.


Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]