This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
elf_backend_check_directives
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org
- Date: Mon, 20 Oct 2008 21:37:13 +1030
- Subject: elf_backend_check_directives
elf_backend_check_directives probably ought to be renamed, since ports
use the hook for purposes other than the original symbian use. This
patch doesn't do that, but at least gives the ppc64 function a name
reflecting its purpose.
* elf64-ppc.c (ppc64_elf_process_dot_syms): Renamed from
ppc64_elf_check_directives.
* elf32-sh-symbian.c (sh_symbian_process_directives): Combine..
(sh_symbian_check_directives): ..this
(bfd_elf32_sh_symbian_process_directives) ..and this function.
Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.287
diff -u -p -r1.287 elf64-ppc.c
--- bfd/elf64-ppc.c 9 Oct 2008 00:55:52 -0000 1.287
+++ bfd/elf64-ppc.c 17 Oct 2008 05:44:10 -0000
@@ -92,7 +92,7 @@ static bfd_vma opd_entry_value
#define elf_backend_create_dynamic_sections ppc64_elf_create_dynamic_sections
#define elf_backend_copy_indirect_symbol ppc64_elf_copy_indirect_symbol
#define elf_backend_add_symbol_hook ppc64_elf_add_symbol_hook
-#define elf_backend_check_directives ppc64_elf_check_directives
+#define elf_backend_check_directives ppc64_elf_process_dot_syms
#define elf_backend_as_needed_cleanup ppc64_elf_as_needed_cleanup
#define elf_backend_archive_symbol_lookup ppc64_elf_archive_symbol_lookup
#define elf_backend_check_relocs ppc64_elf_check_relocs
@@ -3620,7 +3620,7 @@ struct ppc_link_hash_table
/* Set on error. */
unsigned int stub_error:1;
- /* Temp used by ppc64_elf_check_directives. */
+ /* Temp used by ppc64_elf_process_dot_syms. */
unsigned int twiddled_syms:1;
/* Incremented every time we size stubs. */
@@ -4438,7 +4438,7 @@ add_symbol_adjust (struct ppc_link_hash_
/* Process list of dot-symbols we made in link_hash_newfunc. */
static bfd_boolean
-ppc64_elf_check_directives (bfd *ibfd, struct bfd_link_info *info)
+ppc64_elf_process_dot_syms (bfd *ibfd, struct bfd_link_info *info)
{
struct ppc_link_hash_table *htab;
struct ppc_link_hash_entry **p, *eh;
Index: bfd/elf32-sh-symbian.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-sh-symbian.c,v
retrieving revision 1.13
diff -u -p -r1.13 elf32-sh-symbian.c
--- bfd/elf32-sh-symbian.c 30 Jul 2008 04:34:56 -0000 1.13
+++ bfd/elf32-sh-symbian.c 17 Oct 2008 05:44:02 -0000
@@ -392,10 +392,9 @@ sh_symbian_process_embedded_commands (st
/* Scan a bfd for a .directive section, and if found process it.
Returns TRUE upon success, FALSE otherwise. */
-bfd_boolean bfd_elf32_sh_symbian_process_directives (struct bfd_link_info *info, bfd * abfd);
-bfd_boolean
-bfd_elf32_sh_symbian_process_directives (struct bfd_link_info *info, bfd * abfd)
+static bfd_boolean
+sh_symbian_process_directives (bfd *abfd, struct bfd_link_info *info)
{
bfd_boolean result = FALSE;
bfd_byte * contents;
@@ -617,18 +616,12 @@ sh_symbian_relocate_section (bfd *
contents, relocs, local_syms, local_sections);
}
-static bfd_boolean
-sh_symbian_check_directives (bfd *abfd, struct bfd_link_info *info)
-{
- return bfd_elf32_sh_symbian_process_directives (info, abfd);
-}
-
#define TARGET_LITTLE_SYM bfd_elf32_shl_symbian_vec
#define TARGET_LITTLE_NAME "elf32-shl-symbian"
#undef elf_backend_relocate_section
#define elf_backend_relocate_section sh_symbian_relocate_section
#undef elf_backend_check_directives
-#define elf_backend_check_directives sh_symbian_check_directives
+#define elf_backend_check_directives sh_symbian_process_directives
#include "elf32-target.h"
--
Alan Modra
Australia Development Lab, IBM