This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PING : [PATCH] Add support for Xilinx FP/APU to PowerPC
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Michael Eager <eager at eagercon dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 27 May 2008 15:26:21 +0930
- Subject: Re: PING : [PATCH] Add support for Xilinx FP/APU to PowerPC
- References: <480CDDE3.3080103@eagercon.com> <48372E5F.4050505@eagercon.com>
On Fri, May 23, 2008 at 01:51:43PM -0700, Michael Eager wrote:
> Could someone please check this in?
No, it has some errors I think. I glanced at it a month ago, saw
one error and put it aside for a proper review, then forgot about it.
Sorry for the delay.
> +/* Opcode is supported by PowerPC 405 processor. */
> +#define PPC_OPCODE_405 0x10000000
Reuse PPC_OPCODE_PPCPS??
> {"nmaclhwso.", XO (4, 494,1,1),XO_MASK, PPC405|PPC440, {RT, RA, RB}},
> +
> +{"get", APU(4,536), APU_RA_MASK, PPC405 | PPC32, { RT, FSL } },
This isn't the right place to insert these new opcodes. I'm trying to
keep the table more or less sorted, so that you can more easily see
when cpu variants use the same opcode for different instructions.
So "get" ought to go after "evnot", "cget" after "evcmpeq" and so on.
--
Alan Modra
Australia Development Lab, IBM