This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gold script handling of program headers


From: Ian Lance Taylor <iant@google.com>
Date: Tue, 15 Apr 2008 15:51:29 -0700

> 2008-04-15  Ian Lance Taylor  <iant@google.com>
> 
> 	* script-sections.cc (Script_sections::create_segments): Use
> 	header_size_adjustment even when there is enough room for the
> 	headers.
> 	* testsuite/script_test_4.sh: New file.
> 	* testsuite/script_test_4.t: New file.
> 	* testsuite/Makefile.am (check_SCRIPTS): Add script_test_4.sh.
> 	(check_DATA): Add script_test_4.stdout.
> 	(MOSTLYCLEANFILES): Likewise.
> 	(script_test_4): New target.
> 	(script_test_4.stdout): New target.
> 	* testsuite/Makefile.in: Rebuild.

Ian, every since this commit my builds cannot run the bison parts of
the gold build correctly, I've been fixing it up by hand to test
things:

make[2]: Entering directory `/home/davem/src/BINUTILS/cvs/write/build-sparc-linux/gold'
bison -y @YFLAGS@ -d ../../src/gold/yyscript.y
bison: extra operand `../../src/gold/yyscript.y'
Try `bison --help' for more information.
make[2]: *** [yyscript.c] Error 1

Something is wrong with what you've checked into Makefile.in, it added
this:

@@ -243,10 +243,9 @@ WARN_CFLAGS = @WARN_CFLAGS@
 WARN_CXXFLAGS = @WARN_CXXFLAGS@
 XGETTEXT = @XGETTEXT@
 YACC = @YACC@
+YFLAGS = @YFLAGS@
 ac_ct_CC = @ac_ct_CC@

but nothing substitutes that value during the configure runs, so this
@YFLAGS@ blob gets passed to bison which of course fails.

I guess you didn't notice this because your y.tab.[ch] were uptodate
in your build tree.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]