This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] - binutils - cr16 - opcode patch


Hi Nick,

Here is minor patch for cr16 target opcode files (ie cr16-opc.c and cr16.h file).

Sorry - this patch is not acceptable. It just defines a new variable (cr16_num_optab) without actually using it anywhere. ie the patch, as it stands, is pointless.


If you have a need to define cr16_num_optab, please could you explain it ?

Thank you very much for reviewing the patch.


The "cr16_num_optab" variable has been used in the cr16 simulator sources, so I have added it. Without this variable, the cr16 simulator build could fail with an error message as "undefined variable cr16_num_optab".

I have submitted the cr16 simulator patch for review to gdb-patches mailing
on 15th Feb, 2008.

Thanks,
Swami


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]