This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[RFA:] don't prune warnings for ld run_dump_test
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Date: Sun, 17 Feb 2008 12:32:23 +0100
- Subject: [RFA:] don't prune warnings for ld run_dump_test
linking and objcopy
BCC: hp@axis.com
As mentioned in
<http://sourceware.org/ml/binutils/2008-02/msg00114.html>, the
to-be-released dejagnu (and apparently Debian etch packages
named dejagnu-1.4.4.cvs<mumbledate>) prune warnings a bit
heavier than stock dejagnu-1.4.4, causing a ld-cris/warn3 to
fail. It's pretty dumb to prune warnings when using the
just-compiled ld and objcopy anyway, in particular when we don't
want to lose such messages. So, let's not apply prune_warnings
for invocations where we can match warnings or errors.
Historically, there has been runtime linkers emitting noisy
hey-this-isn't-exactly-the-expected-libc.so-but-ok-then messages
that may require some pruning to be useful for testing, but
well, IMHO, let's avoid testing linker/objcopy messages on such
systems.
Tested native (Fedora core 4) x86_64-unknown-linux-gnu and
crosses to arm-elf, cris-elf, d10v-elf, h8300-elf,
mmix-knuth-mmixware, frv-elf, i686-elf, m68k-elf, ia64-elf,
m6811-elf, mips-elf, mips64-linux, powerpc-vxworks,
powerpc64-linux, sh-linux, sh-elf, sh-vxworks, sparc-vxworks,
spu-elf and i686-linux: all targets AFACT that have one or more
target-specific run_dump_tests that could theoretically be
affected or representing a general target using one.
Ok to commit?
ld/testsuite:
* lib/ld-lib.exp (run_dump_test): Don't apply prune_warnings
for tool invocations where warnings or errors can be matched.
Index: lib/ld-lib.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/lib/ld-lib.exp,v
retrieving revision 1.53
diff -p -u -r1.53 ld-lib.exp
--- lib/ld-lib.exp 11 Jan 2008 09:11:18 -0000 1.53
+++ lib/ld-lib.exp 17 Feb 2008 11:23:39 -0000
@@ -846,7 +846,7 @@ proc run_dump_test { name } {
send_log "$cmd\n"
set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]] "" "/dev/null" "ld.tmp"]
remote_upload host "ld.tmp"
- set comp_output [prune_warnings [file_contents "ld.tmp"]]
+ set comp_output [file_contents "ld.tmp"]
remote_file host delete "ld.tmp"
remote_file build delete "ld.tmp"
set cmdret [lindex $cmdret 0]
@@ -863,7 +863,7 @@ proc run_dump_test { name } {
send_log "$cmd\n"
set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]] "" "/dev/null" "ld.tmp"]
remote_upload host "ld.tmp"
- append comp_output [prune_warnings [file_contents "ld.tmp"]]
+ append comp_output [file_contents "ld.tmp"]
remote_file host delete "ld.tmp"
remote_file build delete "ld.tmp"
set cmdret [lindex $cmdret 0]
brgds, H-P