This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: fix register parsing and suffix recognition
On Thu, Feb 14, 2008 at 7:39 AM, Jan Beulich <jbeulich@novell.com> wrote:
> >>> "H.J. Lu" <hjl.tools@gmail.com> 13.02.08 18:03 >>>
>
> >On Feb 13, 2008 5:20 AM, Jan Beulich <jbeulich@novell.com> wrote:
> >> Names of registers unavailable on the currently selected CPU should
> >> never be parsed successfully (not just for 64-bit ones when .code64 is
> >> not in effect) - these names must revert to ordinary symbol names in
> >> such contexts.
> >
> >Please add some testcases for both Intel and AT&T syntaxes.
>
> I added Intel tests; AT&T tests could only be error message tests (as
> there's no collision between register and symbol name spaces), and
> since I generally consider error message tests of at best marginal use
> I'd like to skip those unless you insist.
>
Don't we have ".att_syntax noprefix"? Can you add a testcase with it?
> Built and tested on i686-pc-linux-gnu and x86_64-unknown-linux-gnu.
>
> +
> + /* XXX
> + if (r->reg_type.bitfield.floatreg && !cpu_arch_flags.bitfield.cpu8087)
> + return (const reg_entry *) NULL; */
> +
>
Please leave it out and you can add it when it is ready.
OK with those 2 changes above. Thanks.
H.J.