This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86 (Intel mode): fix handling of FLAT


>>> "H.J. Lu" <hjl.tools@gmail.com> 13.02.08 18:21 >>>
>On Feb 13, 2008 5:39 AM, Jan Beulich <jbeulich@novell.com> wrote:
>
>> --- 2008-02-13/opcodes/i386-opc.h       2008-02-13 11:13:40.000000000 +0100
>> +++ 2008-02-13/opcodes/i386-opc.h       2008-02-13 14:02:34.000000000 +0100
>> @@ -501,6 +501,8 @@ typedef struct
>>  /* EIZ and RIZ are fake index registers.  */
>>  #define RegEiz (RegEip - 1)
>>  #define RegRiz (RegEiz - 1)
>> +/* FLAT is a fake segment register (Intel mode).  */
>> +#define RegFlat     ((unsigned char) ~0)
>
>Please use (RegRiz - 1) instead of  ((unsigned char) ~0). OK with this change.

Since it was purely an Intel mode change, I already committed this one
(and also the 'bound' one). Also, I don't think there's any need to for
distinct register numbers here - the need to be (and are) qualified by
their register class anyway.

Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]