This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] m68k: Rename %mbb to %mbo.


Hi,

Attached is a patch to rename %mbb to %mbo, which is a CPU register in
fido, a m68k variant.

Various documents consistently use MBO for the Memory Base Offset
register.  I don't remember why I picked MBB in the first place.

For backward compatibility, gas still accepts %mbb, but the
disassembly comes out as %mbo.

Tested by running the gas testsuite.  OK to apply?

Kazu Hirata

gas/
2007-09-26  Kazu Hirata  <kazu@codesourcery.com>

	* config/m68k-parse.h (m68k_register): Use MBO instead of MBB.
	(last_movec_reg): Change to MBO.
	* config/tc-m68k.c (fido_ctrl): Use MBO instead of MBB.
	(m68k_ip): Use MBO instead of MBO.
	(init_table): Use MBO instead of MBO.  Add an entry for mbo.

gas/testsuite/
2007-09-26  Kazu Hirata  <kazu@codesourcery.com>

	* gas/m68k/fido.s: Add tests for %mbo.
	* gas/m68k/fido.d: Update accordingly.

opcodes/
2007-09-26  Kazu Hirata  <kazu@codesourcery.com>

	* m68k-dis.c (print_insn_arg): Use %mbo instead of %mbb.

Index: gas/config/m68k-parse.h
===================================================================
RCS file: /cvs/src/src/gas/config/m68k-parse.h,v
retrieving revision 1.13
diff -u -d -p -r1.13 m68k-parse.h
--- gas/config/m68k-parse.h	3 Jul 2007 11:01:03 -0000	1.13
+++ gas/config/m68k-parse.h	26 Sep 2007 18:13:29 -0000
@@ -131,8 +131,8 @@ enum m68k_register
   MBAR,
   ASID,				/* m5475.  */
   CAC,  		        /* fido added this.  */
-  MBB,
-#define last_movec_reg MBB
+  MBO,
+#define last_movec_reg MBO
   /* End of movec ordering constraints.  */
 
   FPI,
Index: gas/config/tc-m68k.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
retrieving revision 1.98
diff -u -d -p -r1.98 tc-m68k.c
--- gas/config/tc-m68k.c	25 Sep 2007 15:31:05 -0000	1.98
+++ gas/config/tc-m68k.c	26 Sep 2007 18:13:29 -0000
@@ -309,7 +309,7 @@ static const enum m68k_register mcf5485_
   0
 };
 static const enum m68k_register fido_ctrl[] = {
-  SFC, DFC, USP, VBR, CAC, MBB,
+  SFC, DFC, USP, VBR, CAC, MBO,
   0
 };
 #define cpu32_ctrl m68010_ctrl
@@ -3265,7 +3265,7 @@ m68k_ip (char *instring)
             case CAC:
               tmpreg = 0xFFE;
               break;
-            case MBB:
+            case MBO:
               tmpreg = 0xFFF;
               break;
 	    default:
@@ -4006,7 +4006,8 @@ static const struct init_entry init_tabl
   { "mbar2",    MBAR2 },  	/* mcf5249 registers.  */
 
   { "cac",    CAC },  		/* fido registers.  */
-  { "mbb",    MBB },  		/* fido registers.  */
+  { "mbb",    MBO },  		/* fido registers (obsolete).  */
+  { "mbo",    MBO },  		/* fido registers.  */
   /* End of control registers.  */
 
   { "ac", AC },
Index: gas/testsuite/gas/m68k/fido.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/m68k/fido.d,v
retrieving revision 1.2
diff -u -d -p -r1.2 fido.d
--- gas/testsuite/gas/m68k/fido.d	27 Dec 2006 07:22:43 -0000	1.2
+++ gas/testsuite/gas/m68k/fido.d	26 Sep 2007 18:13:29 -0000
@@ -25,17 +25,21 @@ Disassembly of section .text:
 0+020 <foo\+(0x|)20> trapx #15
 0+022 <foo\+(0x|)22> movec %cac,%d0
 0+026 <foo\+(0x|)26> movec %cac,%a0
-0+02a <foo\+(0x|)2a> movec %mbb,%d1
-0+02e <foo\+(0x|)2e> movec %mbb,%a1
+0+02a <foo\+(0x|)2a> movec %mbo,%d1
+0+02e <foo\+(0x|)2e> movec %mbo,%a1
 0+032 <foo\+(0x|)32> movec %d2,%cac
 0+036 <foo\+(0x|)36> movec %a2,%cac
-0+03a <foo\+(0x|)3a> movec %d3,%mbb
-0+03e <foo\+(0x|)3e> movec %a3,%mbb
+0+03a <foo\+(0x|)3a> movec %d3,%mbo
+0+03e <foo\+(0x|)3e> movec %a3,%mbo
 0+042 <foo\+(0x|)42> movec %cac,%d4
 0+046 <foo\+(0x|)46> movec %cac,%a4
-0+04a <foo\+(0x|)4a> movec %mbb,%d5
-0+04e <foo\+(0x|)4e> movec %mbb,%a5
+0+04a <foo\+(0x|)4a> movec %mbo,%d5
+0+04e <foo\+(0x|)4e> movec %mbo,%a5
 0+052 <foo\+(0x|)52> movec %d6,%cac
 0+056 <foo\+(0x|)56> movec %fp,%cac
-0+05a <foo\+(0x|)5a> movec %d7,%mbb
-0+05e <foo\+(0x|)5e> movec %sp,%mbb
+0+05a <foo\+(0x|)5a> movec %d7,%mbo
+0+05e <foo\+(0x|)5e> movec %sp,%mbo
+0+062 <foo\+(0x|)62> movec %mbo,%d0
+0+066 <foo\+(0x|)66> movec %mbo,%a0
+0+06a <foo\+(0x|)6a> movec %d1,%mbo
+0+06e <foo\+(0x|)6e> movec %a1,%mbo
Index: gas/testsuite/gas/m68k/fido.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/m68k/fido.s,v
retrieving revision 1.2
diff -u -d -p -r1.2 fido.s
--- gas/testsuite/gas/m68k/fido.s	27 Dec 2006 07:22:43 -0000	1.2
+++ gas/testsuite/gas/m68k/fido.s	26 Sep 2007 18:13:29 -0000
@@ -35,3 +35,7 @@ foo:	
 	movec %a6,%cac
 	movec %d7,%mbb
 	movec %a7,%mbb
+	movec %mbo,%d0
+	movec %mbo,%a0
+	movec %d1,%mbo
+	movec %a1,%mbo
Index: opcodes/m68k-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/m68k-dis.c,v
retrieving revision 1.28
diff -u -d -p -r1.28 m68k-dis.c
--- opcodes/m68k-dis.c	5 Jul 2007 09:49:02 -0000	1.28
+++ opcodes/m68k-dis.c	26 Sep 2007 18:13:29 -0000
@@ -641,7 +641,7 @@ print_insn_arg (const char *d,
              {"%urp", 0x806}, {"%srp", 0x807}, {"%pcr", 0x808},
 
 	     /* Fido added these.  */
-             {"%cac", 0xffe}, {"%mbb", 0xfff}};
+             {"%cac", 0xffe}, {"%mbo", 0xfff}};
 
 	val = fetch_arg (buffer, place, 12, info);
 	for (regno = sizeof names / sizeof names[0] - 1; regno >= 0; regno--)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]