This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: fix som_get_reloc_upper_bound if no reloc


Hi Tristan,

This seems to be an obvious patch: if there are no relocs, bfd_get_reloc_upper_bound should returns
sizeof (arelent *) for the ending NULL (and not 0).

I am not so sure about this. If the section does not have any relocs associated with it then there should be no need to store anything, not even a NUL reloc. So returning 0 seems to be the correct thing to me.


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]