This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gas/5035: x86_64-pc-mingw32-as.exe failed to work
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: "H.J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 17 Sep 2007 09:36:51 +0200
- Subject: Re: PATCH: PR gas/5035: x86_64-pc-mingw32-as.exe failed to work
Hi J.H.,
> obj-coff.c doesn't check size of def_symbol_in_progress any other
> places. The only difference is set_function is used here.
> set_function is defined as
>
> static symbolS *line_fsym;
> #define set_function(F) (line_fsym = (F), coff_add_linesym (F))
>
> I believe the check is wrong.
Yes, indeed. We should use here the bfd_hostptr_t, or remove it all.
BTW there are 'long' type array allocations, which may should use instead
the bfd_hostptr_t, too. Because the imagebase is getting substracted by
them, which is on 64-bit systems 64-bits wide. Additionally I found a
fwrite of these longs as 4-byte value, without checking the endianess. I
think this is not correct, too ?
Cheers,
i.A. Kai Tietz
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
------------------------------------------------------------------------------------------
OneVision Software Entwicklungs GmbH & Co. KG
Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
Handelsregister: HRA 6744, Amtsgericht Regensburg
KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer:
Ulrike DÃhler, Manuela Kluger