This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: PR gas/5035: x86_64-pc-mingw32-as.exe failed to work


obj-coff.c doesn't check size of def_symbol_in_progress any other
places. The only difference is set_function is used here.
set_function is defined as

static symbolS *line_fsym;
#define set_function(F)         (line_fsym = (F), coff_add_linesym (F))

I believe the check is wrong.


H.J.
----
2007-09-16  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/5035
	* config/obj-coff.c (obj_coff_endef): Remove checking size of
	def_symbol_in_progress.

--- gas/config/obj-coff.c.foo	2007-07-03 06:45:19.000000000 -0700
+++ gas/config/obj-coff.c	2007-09-16 15:07:25.000000000 -0700
@@ -777,7 +777,6 @@ obj_coff_endef (int ignore ATTRIBUTE_UNU
 
   if (SF_GET_FUNCTION (def_symbol_in_progress))
     {
-      know (sizeof (def_symbol_in_progress) <= sizeof (long));
       set_function (def_symbol_in_progress);
       SF_SET_PROCESS (def_symbol_in_progress);
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]