Re: PATCH: --enable-targets=all breaks ranlib

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 14 September 2007, Alan Modra wrote:
> Thanks for checking.  When making the bfd_check_format_matches
> changes, I noticed that the original target and format were not always
> restored on an error return.  So I fixed that problem, tidied the code
> a little, then decided that it is desirable to avoid a malloc if
> possible so kept bfd_check_format as is.
>
> 	* format.c (bfd_check_format_matches): Keep matching targets even
> 	when "matching" is NULL to allow bfd_associated_vector matches.
> 	Consolidate error return code.  Consolidate ok return code.  Always
> 	restore original target and format on error.

applying this to binutils-2.18 makes it work for me in my reduced test case as 
well as the original; building a multilib gcc against binutils 
with --enable-targets=all

thanks
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.