This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Parse NT_GNU_BUILD_ID into elf_obj_tdata->build_id*
- From: Roland McGrath <roland at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 18 Aug 2007 16:33:01 -0700 (PDT)
- Subject: Re: [patch] Parse NT_GNU_BUILD_ID into elf_obj_tdata->build_id*
> (_bfd_elf_make_section_from_shdr): Call ELF_PARSE_NOTES for all the
> sections with the name starting with `.note.'.
This should be driven by sh_type == SHT_NOTE, not by names.
> +static bfd_boolean
> +elfobj_grok_note (bfd *abfd, Elf_Internal_Note *note)
> +{
> + switch (note->type)
This needs to check the name field. The NT_GNU_* type number assignments
only apply to notes with name "GNU" (n_namesz = 4).
Thanks,
Roland