This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix bfd_elf_bfd_from_remote_memory() loadbase
- From: Roland McGrath <roland at redhat dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, binutils at sources dot redhat dot com
- Date: Sun, 12 Aug 2007 21:14:30 -0700 (PDT)
- Subject: Re: [patch] Fix bfd_elf_bfd_from_remote_memory() loadbase
> What I'd like to see is:
> - remove the nonsense PF_R tests.
> - set loadbase using the first header with (p_offset & -p_align) == 0
I'd agree with those changes. It is probably also appropriate to change
how the later part of the function works (the actual data reading).
Removing the PF_R check from the second loop in the existing code will
lead to a redundant second read of the first page in the ia64 vdso case.
But that is a further refinement.
Thanks,
Roland