This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] memory leak in coffgen

From: msnyder at sonic dot net
To: msnyder at sonic dot net, binutils at sourceware dot org
Date: Mon, 30 Jul 2007 20:53:53 -0700 (PDT)
Subject: Re: [PATCH] memory leak in coffgen
References: <4480.12.7.175.2.1185407110.squirrel@webmail.sonic.net> <20070726125019.GH11649@bubble.grove.modra.org> <7198.12.7.175.2.1185820612.squirrel@webmail.sonic.net> <20070731030244.GB23966@bubble.grove.modra.org>

> On Mon, Jul 30, 2007 at 11:36:52AM -0700, msnyder@sonic.net wrote:
>> > On Wed, Jul 25, 2007 at 04:45:10PM -0700, msnyder@sonic.net wrote:
>> >> 	* coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs
>> >> 	are not to be cached, free the temporary buffer.
>> >
>> > OK.
>>
>> Alan, unfortunately, I think I was wrong about this one.
>>
>> We can't free "free_internal" at this point, because its aliased
>> by internal_relocs, and we're going to return that.
>>
>> OK to back out this change?
>
> Yes of course.

Thanks, change reverted.

References:
- [PATCH] memory leak in coffgen
  - From: msnyder
- Re: [PATCH] memory leak in coffgen
  - From: Alan Modra
- Re: [PATCH] memory leak in coffgen
  - From: msnyder
- Re: [PATCH] memory leak in coffgen
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]