This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Don't match PE/EFI target with EFI/PE file
- From: "H.J. Lu" <hjl at lucon dot org>
- To: Pedro Alves <pedro_alves at portugalmail dot pt>
- Cc: Nick Clifton <nickc at redhat dot com>, binutils at sources dot redhat dot com
- Date: Wed, 4 Jul 2007 19:52:00 -0700
- Subject: Re: PATCH: Don't match PE/EFI target with EFI/PE file
- References: <20070606233412.GA18747@lucon.org> <20070608175350.GA23357@lucon.org> <20070609143117.GA25765@lucon.org> <4676AE66.704@redhat.com> <20070704221639.GC4189@bubble.grove.modra.org> <468C3915.6070100@portugalmail.pt>
On Thu, Jul 05, 2007 at 01:19:33AM +0100, Pedro Alves wrote:
> Alan Modra wrote:
> >On Mon, Jun 18, 2007 at 05:10:14PM +0100, Nick Clifton wrote:
> >>>2007-06-09 H.J. Lu <hongjiu.lu@intel.com>
> >>>
> >>> * libpei.h (_bfd_XXi_final_link_postscript): Remove
> >>> duplication.
> >>> (bfd_target_pei_p): New.
> >>> (bfd_target_pei_arch): New
> >>> (bfd_target_efi_p): Likewise.
> >>> (bfd_target_efi_arch): New
> >>> (bfd_pe_executable_p): Use bfd_target_pei_p and
> >>> bfd_target_efi_p.
> >>>
> >>> * peicode.h (arch_type): New enum.
> >>> (pe_arch): New function.
> >>> (pe_bfd_object_p): Don't match PE/EFI target with EFI/PE file
> >>> if there is an EFI/PE target.
> >>Approved - please apply.
> >
> >I believe this patch is responsible for multiple testsuite failures on
> >non-x86 pe targets. eg. arm-wince-pe and mcore-pe. HJ would you
> >please look into it?
> >
>
> I was just looking at it, as it also breaks gdb.
>
> This is what I have now. Minimally tested on arm-wince. It should also
> fix epoc, but I haven't tested it yet. (Posted to minimize work
> duplication with HJ - be my guest to pick it up.)
>
> Cheers,
> Pedro Alves
>
> 2007-07-05 Pedro Alves <pedro_alves@portugalmail.pt>
>
> * libpei.h (bfd_target_pei_p): Handle "epoc-pei".
> (bfd_target_pei_arch): Likewise.
> * peicode.h (arch_type): Add arch_type_arm_little and
> arch_type_arm_big.
> (pe_arch): Handle arm-wince-little, arm-little, arm-wince-big
> and arm-big.
>
Checked in a different fix. Since both PE and EFI are only supported
on x86 and x86-64, there is no need to check for other archs.
H.J.