Re: patch: windres allows string concat

[Kai Tietz <Kai dot Tietz at onevision dot com>]

Hi Nick,

Nick Clifton <nickc@redhat.com> wrote on 24.05.2007 11:24:40:

> Did you test this patch ?  If so, how ?
> [As a general point you should always test patches and always report how 

> you tested them.  Eg in this case by rerunning the binutils testsuite 
> for windres using toolchain and showing that there are no regressions].

Sorry, I missed that. I tested it on a cygwin, x86_64-pc-mingw cross, and 
on native linux.

> Also, since you are adding a new feature, it would be a good idea if you 

> could add a new testcase to check it.
I added an new testcase for test this new feature to windres. 

ChangeLog for binutils/testsuite/
2007-05-24  Kai Tietz  <Kai.Tietz@onevision.com>

        * binutils-all/windres/version_cat.rc: New.
        * binutils-all/windres/version_cat.rsd: New.


Cheers,
 i.A. Kai Tietz




|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer: 
Ulrike DÃhler, Manuela Kluger

Attachment: trcparse.txt
Description: Text document