This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix -z max-page-size
On Wed, Jan 17, 2007 at 07:54:10PM -0800, H. J. Lu wrote:
> On Wed, Jan 17, 2007 at 09:29:41AM -0800, H. J. Lu wrote:
> >
> > I'd like a consistent solution. That is all codes in linker should
> > get the same maximum/common pagesize at any given time. Your change
> > may make fold_name to get a different maximum/common pagesize than
> > the rest of program.
> >
>
> Here is my patch for this issue.
> ld/
>
> 2007-01-17 Jakub Jelinek <jakub@redhat.com>
> H.J. Lu <hongjiu.lu@intel.com>
>
> * emultempl/elf32.em (handle_option): Make sure -z max-page-size
> or -z common-page-size argument is a power of 2. Call
> bfd_emul_set_maxpagesize and bfd_emul_set_commonpagesize.
>
> 2007-01-17 H.J. Lu <hongjiu.lu@intel.com>
>
> * ldmain.c (main): Don't call bfd_emul_set_maxpagesize nor
> bfd_emul_set_commonpagesize.
>
> ld/testsuite/
>
> 2007-01-17 H.J. Lu <hongjiu.lu@intel.com>
>
> * ld-elf/maxpage3.t: New file.
> * ld-elf/maxpage3a.d: Likewise.
> * ld-elf/maxpage3b.d: Likewise.
> * ld-elf/maxpage3c.d: Likewise.
>
Looks good to me.
Jakub