This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: silence warning in libiberty/pex-unix.c

From: Ben Elliston <bje at au1 dot ibm dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: binutils at sourceware dot org, gcc-patches at gcc dot gnu dot org
Date: Fri, 12 Jan 2007 12:59:29 +1100
Subject: Re: PATCH: silence warning in libiberty/pex-unix.c
References: <1168562737.6608.12.camel@localhost> <m3lkk9ujz8.fsf@dhcp-172-18-118-195.corp.google.com>

> > -#define writeerr(s) write (STDERR_FILE_NO, s, strlen (s))
> > +#define writeerr(s) if (write (STDERR_FILE_NO, s, 0) < 0) _exit (-1)
> 
> Just cast the result to (void).  I'll preapprove that patch if that
> works.

Casting function results to (void) is insufficient to eliminate the
warning.  Whether or not that is a bug is debatable, but I certainly
expected it to work when I first tried it.

Ben

Follow-Ups:
- Re: PATCH: silence warning in libiberty/pex-unix.c
  - From: Ian Lance Taylor

References:
- PATCH: silence warning in libiberty/pex-unix.c
  - From: Ben Elliston
- Re: PATCH: silence warning in libiberty/pex-unix.c
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]