This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix tekhex (take 2)

From: Alan Modra <amodra at bigpond dot net dot au>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: binutils at sources dot redhat dot com
Date: Fri, 5 Jan 2007 14:08:22 +1030
Subject: Re: [PATCH] Fix tekhex (take 2)
References: <20070104174106.GU3819@sunsite.mff.cuni.cz> <20070104185347.GV3819@sunsite.mff.cuni.cz>

On Thu, Jan 04, 2007 at 07:53:47PM +0100, Jakub Jelinek wrote:
> 	* texhex.c (first_phase): Don't fall through into the default
> 	case.
> 	(pass_over): Replace abort () calls with return FALSE.  Fix
> 	buffer overflow.

OK.  While you're at it, you might like to rename buffer in pass_over
to src, and delete the redundant pointer.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

References:
- [PATCH] Fix tekhex
  - From: Jakub Jelinek
- [PATCH] Fix tekhex (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]