This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Remember the symbol size if it isn't undefined

From: Nick Clifton <nickc at redhat dot com>
To: "H. J. Lu" <hjl at lucon dot org>
Cc: Sergei Poselenov <sposelenov at emcraft dot com>, binutils at sourceware dot org
Date: Fri, 29 Dec 2006 23:01:42 +1300
Subject: Re: PATCH: Remember the symbol size if it isn't undefined
References: <45926C03.1020100@emcraft.com> <20061229002315.GA8577@lucon.org>

Hi H. J.

The problem is we remember the symbol size for undefined symbol and
later we find out its size changes. Do we really care if an undefined
symble changes size?

I can't imagine why.

2006-12-28 H.J. Lu <hongjiu.lu@intel.com>
	* elflink.c (elf_link_add_object_symbols): Remember the symbol
	size only if it is defined.

Approved - but - please could you also add a testcase to check for this particular bug ?

Cheers
  Nick

Follow-Ups:
- Re: PATCH: Remember the symbol size if it isn't undefined
  - From: H. J. Lu

References:
- BFD internal error when using ld --wrap when building Xenomai with uClibc
  - From: Sergei Poselenov
- PATCH: Remember the symbol size if it isn't undefined
  - From: H. J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]